Made bootstrap more reasonable and based on each dir#3
Open
wadewilliams wants to merge 5 commits intoFirstBuild:masterfrom
wadewilliams:script-bootstrap
Open
Made bootstrap more reasonable and based on each dir#3wadewilliams wants to merge 5 commits intoFirstBuild:masterfrom wadewilliams:script-bootstrap
wadewilliams wants to merge 5 commits intoFirstBuild:masterfrom
wadewilliams:script-bootstrap
Conversation
Contributor
wadewilliams
commented
Mar 27, 2015
wadewilliams
commented
- This contains changes to generateFirebaseLoginAndToken.js
- Not sure if this is a direction worth taking with this --- it does somewhat limit you by requiring exporting the env var before running node against generateFirebaseLoginAndToken, but it gives us a little flexibility because we no longer have to edit the js directly.
- Lack of windows support is a thing, not sure how important that is
- Could really do a lot more here and set up the other scripts to run in a similar fashion
- Probably needs a lot more .gitignore properties set -- I scoped this just to the configuration dir for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.